[all-commits] [llvm/llvm-project] 5d1c98: [mlir][Properties] Shorten "Property" to "Prop" in...

Krzysztof Drewniak via All-commits all-commits at lists.llvm.org
Mon Dec 23 07:55:34 PST 2024


  Branch: refs/heads/users/krzysz00/shorten-prop-names
  Home:   https://github.com/llvm/llvm-project
  Commit: 5d1c98f9a5060f51be27d8a56ddf7ec62b19ab0d
      https://github.com/llvm/llvm-project/commit/5d1c98f9a5060f51be27d8a56ddf7ec62b19ab0d
  Author: Krzysztof Drewniak <krzysdrewniak at gmail.com>
  Date:   2024-12-23 (Mon, 23 Dec 2024)

  Changed paths:
    M mlir/docs/DefiningDialects/Operations.md
    M mlir/include/mlir/Dialect/Affine/IR/AffineOps.td
    M mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
    M mlir/include/mlir/IR/Properties.td
    M mlir/test/lib/Dialect/Test/TestOps.td
    M mlir/test/lib/Dialect/Test/TestOpsSyntax.td
    M mlir/test/mlir-tblgen/op-format-invalid.td
    M mlir/test/mlir-tblgen/op-properties-predicates.td
    M mlir/test/mlir-tblgen/op-properties.td
    M mlir/tools/mlir-tblgen/OpFormatGen.cpp

  Log Message:
  -----------
  [mlir][Properties] Shorten "Property" to "Prop" in most places

Since the property system isn't currently in heavy use, it's probably
the right time to fix a choice I made when expanding ODS property
support.

Specifically, most of the property subclasses, like OptionalProperty
or IntProperty, wrote out the word "Property" in full. The
corresponding classes in the Attribute hierarchy uses the short-form
"Attr" in those cases, as in OptionalAttr or DefaultValuedAttr.

This commit changes all those uses of "Property" to "Prop" in order to
prevent excessively verbose tablegen files that needlessly repeat the
full name of a core concept that can be abbreviated.

So, this commit renames all the FooProperty classes to FooProp, and
keeps the existing names as alias with a Deprecated<> on them to warn
people.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list