[all-commits] [llvm/llvm-project] 642c75: [ORC] Make LazyReexportManager::KeyToReentryAddrs ...

[Lang Hames via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 642c75bfc81577158d27139f04f6617befa5286c
      https://github.com/llvm/llvm-project/commit/642c75bfc81577158d27139f04f6617befa5286c
  Author: Lang Hames <lhames at gmail.com>
  Date:   2024-12-23 (Mon, 23 Dec 2024)

  Changed paths:
    M llvm/include/llvm/ExecutionEngine/Orc/LazyReexports.h
    M llvm/lib/ExecutionEngine/Orc/LazyReexports.cpp

  Log Message:
  -----------
  [ORC] Make LazyReexportManager::KeyToReentryAddrs plural, use vector::insert.

Cleanup to recent LazyReexportManager changes: KeyToReentryAddr now maps to
multiple addrs, so make its name plural. Use vector insert rather than a for
loop.

NFC.


  Commit: 98be16f20f3f0e2ca6f3cf34fe9da25822c21c2d
      https://github.com/llvm/llvm-project/commit/98be16f20f3f0e2ca6f3cf34fe9da25822c21c2d
  Author: Lang Hames <lhames at gmail.com>
  Date:   2024-12-23 (Mon, 23 Dec 2024)

  Changed paths:
    M llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.cpp
    M llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.h
    M llvm/lib/ExecutionEngine/JITLink/COFF_x86_64.cpp

  Log Message:
  -----------
  [JITLink][COFF] Use regular external symbol resolution for __ImageBase.

This fixes a concurrency bug in the COFF_x86_64 backend: lookupAsync was used
to find __ImageBase without blocking to wait for the result.

Rather than adding promises / futures, this patch just adds an external
__ImageBase symbol if needed. This is the canonical JITLink solution for
resolving external symbols, and is simpler and more concurrency friendly than
using promises / futures with lookupAsync.


Compare: https://github.com/llvm/llvm-project/compare/b1fab4f8491a...98be16f20f3f

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications