[all-commits] [llvm/llvm-project] d32509: [RISCV] Rewrite an isel pattern to make it more am...

Craig Topper via All-commits all-commits at lists.llvm.org
Sun Dec 22 13:39:40 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d32509928ba6b4c78b02b8a8499dce056ae6fe52
      https://github.com/llvm/llvm-project/commit/d32509928ba6b4c78b02b8a8499dce056ae6fe52
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2024-12-22 (Sun, 22 Dec 2024)

  Changed paths:
    M llvm/lib/Target/RISCV/RISCVInstrInfo.td

  Log Message:
  -----------
  [RISCV] Rewrite an isel pattern to make it more amenable to GISel. NFC

The result pattern created an i1 constant and then used
ImmSubFromXLen SDNodeXForm on it. GISel cannot handle this construct
the same way as SelectionDAG. The GISel equivalent of the SDNodeXForm
expects a G_CONSTANT, but the emitter can't create that.

Work aound this by splitting the pattern into RV32 and RV64 versions
and hard coding the constant.

Additional changes are needed to import the pattern for GISel so
there's no test.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list