[all-commits] [llvm/llvm-project] c9df8d: [Serialization] Migrate away from PointerUnion::ge...

Kazu Hirata via All-commits all-commits at lists.llvm.org
Sat Dec 21 17:41:02 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c9df8da659acde9445e1de5259d34ccf96948b44
      https://github.com/llvm/llvm-project/commit/c9df8da659acde9445e1de5259d34ccf96948b44
  Author: Kazu Hirata <kazu at google.com>
  Date:   2024-12-21 (Sat, 21 Dec 2024)

  Changed paths:
    M clang/lib/Serialization/MultiOnDiskHashTable.h

  Log Message:
  -----------
  [Serialization] Migrate away from PointerUnion::get (NFC) (#120844)

Note that PointerUnion::get has been soft deprecated in
PointerUnion.h:

  // FIXME: Replace the uses of is(), get() and dyn_cast() with
  //        isa<T>, cast<T> and the llvm::dyn_cast<T>

I'm not touching PointerUnion::dyn_cast for now because it's a bit
complicated; we could blindly migrate it to dyn_cast_if_present, but
we should probably use dyn_cast when the operand is known to be
non-null.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list