[all-commits] [llvm/llvm-project] cf7b3f: Fix double-quotes in diagnostic when attempting to...

[William Tran-Viet via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cf7b3f8d827abba49930202e51702714349c716d
      https://github.com/llvm/llvm-project/commit/cf7b3f8d827abba49930202e51702714349c716d
  Author: William Tran-Viet <wtranviet at proton.me>
  Date:   2024-12-20 (Fri, 20 Dec 2024)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/Sema/SemaExprMember.cpp
    M clang/test/SemaCXX/vector-bool.cpp

  Log Message:
  -----------
  Fix double-quotes in diagnostic when attempting to access a ext_vector of bools (#118186)

Fixes #116932 

- Remove the quotation marks in the diagnostic message for
err_ext_vector_component_name_illegal
- Pass in the quotation marks directly when reporting an illegal vector
component name inside `CheckExtVectorComponent`
- Add an offset to the `OpLoc` passed into `S.Diag` so the error message
arrow points directly to the offending illegal component rather than to
the '.' at the start of the component identifier.
- Modify the `vector-bool.cpp` element-wise access test case so it
(correctly) now only expects a single set of quotes.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications