[all-commits] [llvm/llvm-project] 7f2fb8: [memprof] Don't use Frame::hash or hashCallStacks ...

[Kazu Hirata via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7f2fb8061e97ff21caa04b9c44cac2f599202232
      https://github.com/llvm/llvm-project/commit/7f2fb8061e97ff21caa04b9c44cac2f599202232
  Author: Kazu Hirata <kazu at google.com>
  Date:   2024-12-17 (Tue, 17 Dec 2024)

  Changed paths:
    M llvm/unittests/ProfileData/MemProfTest.cpp

  Log Message:
  -----------
  [memprof] Don't use Frame::hash or hashCallStacks in unit test (#119984)

This patch checks the result of YAML parsing at the level of
MemProfRecord instead of IndexedMemProfRecord, thereby avoiding use of
Frame::hash and hashCallStacks.  This makes sense because we
ultimately care about consumers like MemProfiler.cpp obtaining
MemProfRecord correctly; IndexedMemProfData and hash values are just
intermediaries.

Once this patch lands, we call Frame::hash and hashCallStacks only
when adding Frames or call stacks to their respective data structures.
In other words, the hash functions are pretty much business internal
to IndexedMemProfRecord.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications