[all-commits] [llvm/llvm-project] fbbbd6: [MLIR] correct return type of parse() functions (#...

Timothy Hoffman via All-commits all-commits at lists.llvm.org
Tue Dec 17 09:07:17 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fbbbd65b2573dc92c3c2272ce57da29cf8227a35
      https://github.com/llvm/llvm-project/commit/fbbbd65b2573dc92c3c2272ce57da29cf8227a35
  Author: Timothy Hoffman <4001421+tim-hoffman at users.noreply.github.com>
  Date:   2024-12-17 (Tue, 17 Dec 2024)

  Changed paths:
    M mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
    M mlir/lib/Dialect/LLVMIR/IR/LLVMAttrs.cpp
    M mlir/test/lib/Dialect/Test/TestTypes.cpp

  Log Message:
  -----------
  [MLIR] correct return type of parse() functions (#120180)

The `parseX()` functions that are defined to support `custom<X>` in
`assemblyFormat` should return `ParseResult` rather than
`LogicalResult`. The `ParseResult` type is necessary due to tablegen
generating code that expects this type within an Op `parseX()` function.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list