[all-commits] [llvm/llvm-project] 991929: [mlir][gpu] Adding ELF section option to the gpu-m...

[Renaud Kauffmann via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9919295cfd05222159246d7448ec42392e98fbf2
      https://github.com/llvm/llvm-project/commit/9919295cfd05222159246d7448ec42392e98fbf2
  Author: Renaud Kauffmann <rkauffmann at nvidia.com>
  Date:   2024-12-16 (Mon, 16 Dec 2024)

  Changed paths:
    M mlir/include/mlir/Dialect/GPU/IR/CompilationInterfaces.h
    M mlir/include/mlir/Dialect/GPU/Transforms/Passes.td
    M mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
    M mlir/lib/Dialect/GPU/Transforms/ModuleToBinary.cpp
    M mlir/lib/Target/LLVM/NVVM/Target.cpp
    M mlir/lib/Target/LLVMIR/Dialect/GPU/SelectObjectAttr.cpp
    M mlir/test/Dialect/GPU/module-to-binary-nvvm.mlir
    M mlir/unittests/Target/LLVM/SerializeNVVMTarget.cpp
    M mlir/unittests/Target/LLVM/SerializeROCDLTarget.cpp
    M mlir/unittests/Target/LLVM/SerializeToLLVMBitcode.cpp

  Log Message:
  -----------
  [mlir][gpu] Adding ELF section option to the gpu-module-to-binary pass (#119440)

This is a follow-up of #117246.

I thought then it would be easy to edit a DictionaryAttr but it turns
out that these attributes are immutable and need to be passed during the
construction of the gpu.binary Op.

The first commit was using the NVVMTargetAttr to pass the information.
After feedback from @fabianmcg, this PR now passes the information
through a new option of the gpu-module-to-binary pass.

Please add reviewers, as you see fit.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications