[all-commits] [llvm/llvm-project] b0746c: [mlir-tblgen] Migrate away from PointerUnion::{is, ...

[Kazu Hirata via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b0746c68629c26567cd123d8f9b28e796ef26f47
      https://github.com/llvm/llvm-project/commit/b0746c68629c26567cd123d8f9b28e796ef26f47
  Author: Kazu Hirata <kazu at google.com>
  Date:   2024-12-15 (Sun, 15 Dec 2024)

  Changed paths:
    M mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
    M mlir/tools/mlir-tblgen/OpPythonBindingGen.cpp
    M mlir/tools/mlir-tblgen/RewriterGen.cpp
    M mlir/tools/mlir-tblgen/SPIRVUtilsGen.cpp

  Log Message:
  -----------
  [mlir-tblgen] Migrate away from PointerUnion::{is,get} (NFC) (#119994)

Note that PointerUnion::{is,get} have been soft deprecated in
PointerUnion.h:

  // FIXME: Replace the uses of is(), get() and dyn_cast() with
  //        isa<T>, cast<T> and the llvm::dyn_cast<T>

I'm not touching PointerUnion::dyn_cast for now because it's a bit
complicated; we could blindly migrate it to dyn_cast_if_present, but
we should probably use dyn_cast when the operand is known to be
non-null.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications