[all-commits] [llvm/llvm-project] 737d78: [Darwin][Driver][clang] Prioritise command line ar...

[Carlo Cabrera via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 737d78a9785ea3e928de2b36a4e3e7decd8c9491
      https://github.com/llvm/llvm-project/commit/737d78a9785ea3e928de2b36a4e3e7decd8c9491
  Author: Carlo Cabrera <github at carlo.cab>
  Date:   2024-12-12 (Thu, 12 Dec 2024)

  Changed paths:
    M clang/lib/Driver/ToolChains/Darwin.cpp
    M clang/test/Driver/sysroot.c

  Log Message:
  -----------
  [Darwin][Driver][clang] Prioritise command line args over `DEFAULT_SYSROOT` (#115993)

If a toolchain is configured with `DEFAULT_SYSROOT`, then this could
result in an unintended value for `-syslibroot` being passed to the
linker if the user manually sets `-isysroot` or `SDKROOT`.

Let's fix this by prioritising command line flags when determining
`-syslibroot` before checking `getSysRoot`.

Downstream bug report:
https://github.com/Homebrew/homebrew-core/issues/197277

Co-authored-by: Bo Anderson <mail at boanderson.me>

Co-authored-by: Bo Anderson <mail at boanderson.me>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications