[all-commits] [llvm/llvm-project] 04269e: [AMDGPU] Re-enable closed-world assumption as an o...

Shilei Tian via All-commits all-commits at lists.llvm.org
Tue Dec 10 12:58:02 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 04269ea0e40abb3c5aa0c96adde65c72195cbb6e
      https://github.com/llvm/llvm-project/commit/04269ea0e40abb3c5aa0c96adde65c72195cbb6e
  Author: Shilei Tian <i at tianshilei.me>
  Date:   2024-12-10 (Tue, 10 Dec 2024)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
    A llvm/test/LTO/AMDGPU/closed-world-assumption.ll

  Log Message:
  -----------
  [AMDGPU] Re-enable closed-world assumption as an opt-in feature (#115371)

Although the ABI (if one exists) doesn’t explicitly prohibit
cross-code-object function calls—particularly since our loader can
handle them—such calls are not actually allowed in any of the officially
supported programming models. However, this limitation has some nuances.
For instance, the loader can handle cross-code-object global variables,
which complicates the situation further.

Given this complexity, assuming a closed-world model at link time isn’t
always safe. To address this, this PR introduces an option that enables
this assumption, providing end users the flexibility to enable it for
improved compiler optimizations. However, it is the user’s
responsibility to ensure they do not violate this assumption.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list