[all-commits] [llvm/llvm-project] a2d086: [AMDGPU] Fix FMA combine (#119217)

[Piotr Sobczak via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a2d086af2cdac8c22685551d4d3d0928e40e1a0f
      https://github.com/llvm/llvm-project/commit/a2d086af2cdac8c22685551d4d3d0928e40e1a0f
  Author: Piotr Sobczak <piotr.sobczak at amd.com>
  Date:   2024-12-10 (Tue, 10 Dec 2024)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SIISelLowering.cpp
    M llvm/test/CodeGen/AMDGPU/fdot2.ll

  Log Message:
  -----------
  [AMDGPU] Fix FMA combine (#119217)

Update the check in the FMA combine to check dot10-insts instead of
dot7-insts.

The target of the combine, v_dot2_f32_f16, is available only if
dot10-insts target feature is enabled.

The issue probably dates back to the change that split out dot10-insts
out of dot7-insts.

As far as I can see, this does not affect any current targets, but if a
future target has dot7-insts, but not dot10-insts that would cause a
crash ("cannot select") for the input ir in the test.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications