[all-commits] [llvm/llvm-project] 83cb3d: [Serialization] Migrate away from PointerUnion::{i...

Kazu Hirata via All-commits all-commits at lists.llvm.org
Mon Dec 9 09:48:00 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 83cb3dbc0c7c1c6950d52412e3346e3b382d79d6
      https://github.com/llvm/llvm-project/commit/83cb3dbc0c7c1c6950d52412e3346e3b382d79d6
  Author: Kazu Hirata <kazu at google.com>
  Date:   2024-12-09 (Mon, 09 Dec 2024)

  Changed paths:
    M clang/lib/Serialization/ASTReaderDecl.cpp
    M clang/lib/Serialization/ASTReaderStmt.cpp
    M clang/lib/Serialization/ASTWriter.cpp
    M clang/lib/Serialization/ASTWriterDecl.cpp
    M clang/lib/Serialization/ASTWriterStmt.cpp

  Log Message:
  -----------
  [Serialization] Migrate away from PointerUnion::{is,get} (NFC) (#118948)

Note that PointerUnion::{is,get} have been soft deprecated in
PointerUnion.h:

  // FIXME: Replace the uses of is(), get() and dyn_cast() with
  //        isa<T>, cast<T> and the llvm::dyn_cast<T>

I'm not touching PointerUnion::dyn_cast for now because it's a bit
complicated; we could blindly migrate it to dyn_cast_if_present, but
we should probably use dyn_cast when the operand is known to be
non-null.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list