[all-commits] [llvm/llvm-project] b9a209: [libc] Remove unused target conditionals for Apple...

[Louis Dionne via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b9a209725bbb910d330e3746dceb88b59c4d8174
      https://github.com/llvm/llvm-project/commit/b9a209725bbb910d330e3746dceb88b59c4d8174
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2024-12-09 (Mon, 09 Dec 2024)

  Changed paths:
    M libc/src/__support/macros/properties/os.h

  Log Message:
  -----------
  [libc] Remove unused target conditionals for Apple platforms (#119030)

It seems that LIBC_TARGET_OS_IS_MACOS and LIBC_TARGET_OS_IS_IPHONE were
never actually used in the code, so these definitions can be removed.

I came across these because libc++ now depends on llvm-libc to build
(for from_chars), and the unguarded use of TargetConditionals.h broke
some of our downstream configurations. There are some platforms for
which `__APPLE__` is defined but that don't provide TargetConditionals.h.

If there is a need to keep defining those, the compiler also provides
some uglier macro definitions like __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__
that do not require including any header.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications