[all-commits] [llvm/llvm-project] 6c062a: [memprof] Compare Frames instead of FrameIds in a ...

[Kazu Hirata via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6c062afc2e6ed4329e1e14cb011913195a5356fa
      https://github.com/llvm/llvm-project/commit/6c062afc2e6ed4329e1e14cb011913195a5356fa
  Author: Kazu Hirata <kazu at google.com>
  Date:   2024-12-08 (Sun, 08 Dec 2024)

  Changed paths:
    M llvm/unittests/ProfileData/MemProfTest.cpp

  Log Message:
  -----------
  [memprof] Compare Frames instead of FrameIds in a unit test (#119111)

When we call IndexedMemProfRecord::toMemProfRecord, we care about
getting the original (that is, non-indexed) MemProfRecord back, so we
should just verify that, not the hash values, which are
intermediaries.

There is a remote possibility of hash collisions where call stack
{F1, F2} might come back as {F1, F1} if F1.hash() == F2.hash() for
example.  However, since FrameId uses BLAKE, the hash values should be
consistent across architectures.  That is, if this test case works on
one architecture, it should work on others as well.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications