[all-commits] [llvm/llvm-project] bc624a: [mlir][vector][nfc] Update vector-to-llvm.mlir (#1...

[Andrzej Warzyński via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bc624a56c731702d0834e4641e59c532eda04d2e
      https://github.com/llvm/llvm-project/commit/bc624a56c731702d0834e4641e59c532eda04d2e
  Author: Andrzej Warzyński <andrzej.warzynski at arm.com>
  Date:   2024-12-07 (Sat, 07 Dec 2024)

  Changed paths:
    M mlir/test/Conversion/VectorToLLVM/vector-to-llvm.mlir

  Log Message:
  -----------
  [mlir][vector][nfc] Update vector-to-llvm.mlir (#118112)

* Adds extra comments to group Ops
* Unifies the test function naming, i.e.
  * `@vector_{op_name}_{variant}` -> `@{op_name}_{variant}`
* Unifies input variable names (`%input` -> `%arg0`)
* Capitalises LIT variable names (e.g. `%[[insert]]` --> `%[[INSERT]]`)
* Moves `@step_scalable()` _below_ its "fixed-width" counterpart
  (to follow the existing consistency within this file).

There's still some inconsistencies within this file - I'm happy to send
more updates if folks find it useful. But I'd definitely recommend
splitting across multiple PRs (otherwise it's hard to review).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications