[all-commits] [llvm/llvm-project] 6f5bff: [mlir-tblgen] Relax builder ambiguity check (#118310)

[RoboTux via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6f5bffdfc0476d50a4dbcdba6946893ea3b0e2c8
      https://github.com/llvm/llvm-project/commit/6f5bffdfc0476d50a4dbcdba6946893ea3b0e2c8
  Author: Thomas Preud'homme <thomas.preudhomme at arm.com>
  Date:   2024-12-06 (Fri, 06 Dec 2024)

  Changed paths:
    M mlir/include/mlir/Dialect/Arith/IR/ArithOps.td
    M mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
    M mlir/test/mlir-tblgen/op-default-builder.td
    M mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

  Log Message:
  -----------
  [mlir-tblgen] Relax builder ambiguity check (#118310)

The mlir-tblgen tool prevents the parameter of the build() constructor
for the first default-valued attribute of an operation from having a
default value to avoid ambiguity with the corresponding build()
constructor taking unwrapped value. However it does so even when earlier
wrapped unwrappable attribute would lift the ambiguity. This commit
relax the logic accordingly, which allows to remove a manual constructor
in Arith dialect.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications