[all-commits] [llvm/llvm-project] abb691: [lldb] Add additional assertions to TestVTableValu...

Alex Langford via All-commits all-commits at lists.llvm.org
Thu Dec 5 10:38:45 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: abb6919a63c7ef017bb4f9c86057adcdb8129964
      https://github.com/llvm/llvm-project/commit/abb6919a63c7ef017bb4f9c86057adcdb8129964
  Author: Alex Langford <alangford at apple.com>
  Date:   2024-12-05 (Thu, 05 Dec 2024)

  Changed paths:
    M lldb/test/API/functionalities/vtable/TestVTableValue.py

  Log Message:
  -----------
  [lldb] Add additional assertions to TestVTableValue.test_overwrite_vtable (#118719)

If this test fails, you're likely going to see something like "Assertion
Error: A != B" which doesn't really give much explanation for why this
failed.

Instead of ignoring the error, we should assert that it succeeded. This
will lead to a better error message, for example:
`AssertionError: 'memory write failed for 0x102d7c018' is not success`



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list