[all-commits] [llvm/llvm-project] f1d81d: [ASTWriter] Do not allocate source location space ...

[Ilya Biryukov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f1d81dbd0573502134270495aa43e3ffb3193ab0
      https://github.com/llvm/llvm-project/commit/f1d81dbd0573502134270495aa43e3ffb3193ab0
  Author: Ilya Biryukov <ibiryukov at google.com>
  Date:   2024-12-05 (Thu, 05 Dec 2024)

  Changed paths:
    M clang/lib/Serialization/ASTWriter.cpp
    A clang/test/Modules/prune-non-affecting-module-map-repeated-textual.cpp

  Log Message:
  -----------
  [ASTWriter] Do not allocate source location space for module maps used only for textual headers (#116374)

This is a follow up to #112015 and it reduces the unnecessary
duplication of source locations further.

We do not need to allocate source location space in the serialized PCMs
for module maps used only to find textual headers. Those module maps are
never referenced from anywhere in the serialized ASTs and are re-read in
other compilations.
This change should not affect correctness of Clang compilations or
clang-scan-deps in any way.

We do need the InputFile entry in the serialized AST because
clang-scan-deps relies on it. The previous patch introduced a mechanism
to do exactly that.

We have found that to finally remove any duplication of module maps we
use internally in our build system.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications