[all-commits] [llvm/llvm-project] ff5953: [lldb-dap] Support finding the lldb-dap binary (#1...

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ff5953804ea5b430710b07f1dae395bfcf6d35d0
      https://github.com/llvm/llvm-project/commit/ff5953804ea5b430710b07f1dae395bfcf6d35d0
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2024-12-04 (Wed, 04 Dec 2024)

  Changed paths:
    M lldb/tools/lldb-dap/package.json
    M lldb/tools/lldb-dap/src-ts/debug-adapter-factory.ts
    M lldb/tools/lldb-dap/src-ts/extension.ts
    R lldb/tools/lldb-dap/src-ts/types.ts

  Log Message:
  -----------
  [lldb-dap] Support finding the lldb-dap binary (#118547)

Support finding the lldb-dap binary with `xcrun` on Darwin or in PATH on
all other platforms.

Unfortunately, this PR is larger than I would like because it removes
the `lldbDapOptions`. I believe these options are not necessary, and as
previously implemented, they caused a spurious warning with this change.
The problem was that the options were created before the custom factory.
By moving the creation logic into the factory, we make sure it's only
called after the factory has been registered. The upside is that this
simplifies the code and removes a level of indirection.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications