[all-commits] [llvm/llvm-project] a8f927: [mlir][Vector] Fix vector.extract lowering to llvm...

[Kunwar Grover via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a8f927161bc25fe70d367c64e44211a15767d03e
      https://github.com/llvm/llvm-project/commit/a8f927161bc25fe70d367c64e44211a15767d03e
  Author: Kunwar Grover <groverkss at gmail.com>
  Date:   2024-12-04 (Wed, 04 Dec 2024)

  Changed paths:
    M mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp
    M mlir/test/Conversion/VectorToLLVM/vector-to-llvm.mlir

  Log Message:
  -----------
  [mlir][Vector] Fix vector.extract lowering to llvm for 0-d vectors (#117731)

The current implementation of lowering to llvm for vector.extract
incorrectly assumes that if the number of indices is zero, the operation
can be folded away. This PR removes this condition and relies on the
folder to do it instead.

This PR also unifies the logic for scalar extracts and slice extracts,
which as a side effect also enables vector.extract lowering for n-d
vector.extract with dynamic inner most dimension. (This was only
prevented by a conservative check in the old implementation)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications