[all-commits] [llvm/llvm-project] 4ab499: remove new over-assertive assert

[jeanPerier via All-commits]

  Branch: refs/heads/users/jperier/array_call_opt
  Home:   https://github.com/llvm/llvm-project
  Commit: 4ab4992246fddf1eef2131d2a6d341095feba85f
      https://github.com/llvm/llvm-project/commit/4ab4992246fddf1eef2131d2a6d341095feba85f
  Author: Jean Perier <jperier at nvidia.com>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M flang/lib/Optimizer/HLFIR/IR/HLFIRDialect.cpp

  Log Message:
  -----------
  remove new over-assertive assert

I added an assert that prevents ExprType to be "trivial types" (i32, f32, ...)
but that actually breaks existing lowering code that generate as_expr + associate
patterns to create temporaries:

https://github.com/llvm/llvm-project/blob/03b5f8f0f0d10c412842ed04b90e2217cf071218/flang/lib/Lower/ConvertCall.cpp#L1271

```
subroutine trivial_as_expr(i)
  integer, optional :: i
  interface
    subroutine foo(j)
      integer, optional, value :: j
    end subroutine
  end interface
  call foo(i)
end subroutine
```

This is unrelated to this patch, so leave it like this (it is not even a
functional problem).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications