[all-commits] [llvm/llvm-project] 332719: [mlir][LLVM][NFC] Implement `print/parse` for `LLV...

Markus Böck via All-commits all-commits at lists.llvm.org
Thu Nov 28 00:19:52 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 332719561000dcac94384234ace1fa959362ad8e
      https://github.com/llvm/llvm-project/commit/332719561000dcac94384234ace1fa959362ad8e
  Author: Markus Böck <markus.boeck02 at gmail.com>
  Date:   2024-11-28 (Thu, 28 Nov 2024)

  Changed paths:
    M mlir/include/mlir/Dialect/LLVMIR/LLVMTypes.td
    M mlir/lib/Dialect/LLVMIR/IR/LLVMTypeSyntax.cpp
    M mlir/lib/Dialect/LLVMIR/IR/LLVMTypes.cpp

  Log Message:
  -----------
  [mlir][LLVM][NFC] Implement `print/parse` for `LLVMStructType` (#117930)

The printing and parsing logic for struct types was still using ad-hoc
functions instead of the more conventional `print` and `parse` methods
whose declarations are automatically generated by TableGen.

This PR effectively renames these functions and uses them directly as
implementations for `print` and `parse` of `LLVMStructType`.

This additionally fixes linking errors when users or auto generated code
may call `print` and `parse` directly.

Fixes https://github.com/llvm/llvm-project/issues/117927



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list