[all-commits] [llvm/llvm-project] 345b33: [AMDGPU][SplitModule] Fix unintentional integer di...

Fraser Cormack via All-commits all-commits at lists.llvm.org
Wed Nov 27 02:19:13 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 345b3319c8544a0124aed9602c31f8793228ab63
      https://github.com/llvm/llvm-project/commit/345b3319c8544a0124aed9602c31f8793228ab63
  Author: Fraser Cormack <fraser at codeplay.com>
  Date:   2024-11-27 (Wed, 27 Nov 2024)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUSplitModule.cpp

  Log Message:
  -----------
  [AMDGPU][SplitModule] Fix unintentional integer division (#117586)

A static analysis tool warned that a division was always being performed
in integer division, so was either 0.0 or 1.0.

This doesn't seem intentional, so has been fixed to return a true ratio
using floating-point division. This in turn showed a bug where a
comparison against this ratio was incorrect.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list