[all-commits] [llvm/llvm-project] e33556: [NFC][flang] Fix execute_command_line test for odd...

[David Truby via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e335563806e0466f33ecce80a9fd5a39a3aead47
      https://github.com/llvm/llvm-project/commit/e335563806e0466f33ecce80a9fd5a39a3aead47
  Author: David Truby <david.truby at arm.com>
  Date:   2024-11-27 (Wed, 27 Nov 2024)

  Changed paths:
    M flang/unittests/Runtime/CMakeLists.txt
    M flang/unittests/Runtime/CommandTest.cpp

  Log Message:
  -----------
  [NFC][flang] Fix execute_command_line test for odd environments (#117714)

One of the execute_command_line tests currently runs `cat` on an invalid
file and checks its return value, but since we don't control `cat` or
the user's path, the return value might not be reliably stable on a
per-platform basis. For example, if `git` is installed on Windows in
certain configurations it adds a directory to the path containing a
`cat` with a different set of error codes to the default Windows one.

This patch changes the test to use the `not` binary built by LLVM for
testing purposes, which should always return 1 on any platform
regardless of the user's environment.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications