[all-commits] [llvm/llvm-project] c9e606: [mlir] Improve doc in `OpFormatGen.cpp` (NFC) (#11...

[lorenzo chelini via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c9e606b9cf50b822aca2a3dc5762fb77e9b976bd
      https://github.com/llvm/llvm-project/commit/c9e606b9cf50b822aca2a3dc5762fb77e9b976bd
  Author: lorenzo chelini <l.chelini at icloud.com>
  Date:   2024-11-25 (Mon, 25 Nov 2024)

  Changed paths:
    M mlir/tools/mlir-tblgen/OpFormatGen.cpp

  Log Message:
  -----------
  [mlir] Improve doc in `OpFormatGen.cpp` (NFC) (#117564)

The comment is misleading because attributes do not have
`elidePrintingDefaultValue` bit. It appears that
`elidePrintingDefaultValue` was never merged upstream (see:
https://reviews.llvm.org/D135398 ), but the comment was likely
introduced by mistake in a later revision
(https://reviews.llvm.org/D135993.).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications