[all-commits] [llvm/llvm-project] 782d01: AMDGPU: Remove wavefrontsize64 feature from dummy ...

[Matt Arsenault via All-commits]

  Branch: refs/heads/users/arsenm/remove-wave64-feature-from-default-target
  Home:   https://github.com/llvm/llvm-project
  Commit: 782d01f9b00b49ca2b20564b33f21c526d8aa716
      https://github.com/llvm/llvm-project/commit/782d01f9b00b49ca2b20564b33f21c526d8aa716
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2024-11-23 (Sat, 23 Nov 2024)

  Changed paths:
    M llvm/lib/Target/AMDGPU/GCNProcessors.td
    M llvm/lib/Target/AMDGPU/GCNSubtarget.cpp
    M llvm/lib/Target/AMDGPU/GCNSubtarget.h
    M llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp
    M llvm/test/MC/AMDGPU/wave_any.s

  Log Message:
  -----------
  AMDGPU: Remove wavefrontsize64 feature from dummy target

This is a refinement for the existing hack. With this,
the default target will have neither wavefrontsize feature
present, unless it was explicitly specified. That is,
getWavefrontSize() == 64 no longer implies +wavefrontsize64.
getWavefrontSize() == 32 does imply +wavefrontsize32.

Continue to assume the value is 64 with no wavesize feature.
This maintains the codegenable property without any code
that directly cares about the wavesize needs to worry about it.

Introduce an isWaveSizeKnown helper to check if we know the
wavesize is accurate based on having one of the features explicitly
set, or a known target-cpu.

I'm not sure what's going on in wave_any.s. It's testing what
happens when both wavesizes are enabled, but this is treated
as an error in codegen. We now treat wave32 as the winning
case, so some cases that were previously printed as vcc are now
vcc_lo.


  Commit: 6fa5b9a813022c3d398f60a92d26eafa99d44f92
      https://github.com/llvm/llvm-project/commit/6fa5b9a813022c3d398f60a92d26eafa99d44f92
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2024-11-23 (Sat, 23 Nov 2024)

  Changed paths:
    M llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp

  Log Message:
  -----------
  check if wave32 in disassembler


Compare: https://github.com/llvm/llvm-project/compare/79ff6e6f7e63...6fa5b9a81302

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications