[all-commits] [llvm/llvm-project] 7553fb: [lldb] Fix a regression in SBValue::GetObjectDescr...

[Adrian Prantl via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7553fb127485d034e2ffdbb5461fef2b6f04b989
      https://github.com/llvm/llvm-project/commit/7553fb127485d034e2ffdbb5461fef2b6f04b989
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2024-11-21 (Thu, 21 Nov 2024)

  Changed paths:
    M lldb/source/API/SBValue.cpp
    M lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py

  Log Message:
  -----------
  [lldb] Fix a regression in SBValue::GetObjectDescription()  (#117242)

The old behavior was to return a null string in the error case,when
refactoring the error handling I thought it would be a good idea to
print the error in the description, but that breaks clients that try to
print a description first and then do something else in the error case.
The API is not great but it's clear that in-band errors are also not a
good idea.

rdar://133956263



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications