[all-commits] [llvm/llvm-project] 9e8200: [mlir][Affine] Expand affine.[de]linearize_index w...

[Krzysztof Drewniak via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9e8200c7184431e0dd0e235b70cabfbe8bfe351d
      https://github.com/llvm/llvm-project/commit/9e8200c7184431e0dd0e235b70cabfbe8bfe351d
  Author: Krzysztof Drewniak <Krzysztof.Drewniak at amd.com>
  Date:   2024-11-21 (Thu, 21 Nov 2024)

  Changed paths:
    M mlir/include/mlir/Dialect/Affine/LoopUtils.h
    M mlir/include/mlir/Dialect/Affine/Passes.h
    M mlir/include/mlir/Dialect/Affine/Passes.td
    M mlir/include/mlir/Dialect/Affine/Transforms/Transforms.h
    M mlir/lib/Dialect/Affine/Transforms/AffineExpandIndexOps.cpp
    A mlir/lib/Dialect/Affine/Transforms/AffineExpandIndexOpsAsAffine.cpp
    M mlir/lib/Dialect/Affine/Transforms/CMakeLists.txt
    M mlir/lib/Dialect/Affine/Utils/LoopUtils.cpp
    M mlir/test/Conversion/AffineToStandard/lower-affine.mlir
    A mlir/test/Dialect/Affine/affine-expand-index-ops-as-affine.mlir
    M mlir/test/Dialect/Affine/affine-expand-index-ops.mlir

  Log Message:
  -----------
  [mlir][Affine] Expand affine.[de]linearize_index without affine maps (#116703)

As the documentation for -affine-expand-index-ops says,
affine.delinearize_index and affine.linearize_index don't need to be
expanded into the affine dialect.

Expanding these operations into affine.apply operations can introduce
unwanted "simplifications", mainly translations of `(dN mod C + ...)` to
`(dN + ... - (dN floordiv C) * C)` and similar, which create worse
generated code. This commit resolves this issue by expanding out
affine.delanierize_index directly.

In addition, the lowering of affine.linearize_index now sorts the
operands by loop-independence, allowing an increased amount of
loop-invariant code motion after lowering.

The old behavior is preserved as -expand-affine-index-ops-as-affine but
is no longer the default



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications