[all-commits] [llvm/llvm-project] 4b5a8d: [lldb] Make sure completions don't end with newlin...

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Thu Nov 21 08:00:54 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4b5a8d6835897477873242ef1ee529d00dedd9a1
      https://github.com/llvm/llvm-project/commit/4b5a8d6835897477873242ef1ee529d00dedd9a1
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2024-11-21 (Thu, 21 Nov 2024)

  Changed paths:
    M lldb/include/lldb/Utility/CompletionRequest.h

  Log Message:
  -----------
  [lldb] Make sure completions don't end with newlines (#117054)

The logic that prints completions and their descriptions assumes neither
the completion itself nor the description ends with a newline. I
considered making this an assert, but decided against it as completions
can indirectly come from user input (e.g. oddly crafted names). Instead,
avoid the potential for mistakes by defensively stripping them.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list