[all-commits] [llvm/llvm-project] ef102b: [MachineLICM] Don't allow hoisting invariant loads...

[Florian Hahn via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ef102b4a6333a304e36dc623d5381257a7ef1ed6
      https://github.com/llvm/llvm-project/commit/ef102b4a6333a304e36dc623d5381257a7ef1ed6
  Author: Florian Hahn <flo at fhahn.com>
  Date:   2024-11-21 (Thu, 21 Nov 2024)

  Changed paths:
    M llvm/lib/CodeGen/MachineLICM.cpp
    M llvm/test/CodeGen/AArch64/machine-licm-hoist-load.ll
    M llvm/test/CodeGen/Mips/lcb5.ll

  Log Message:
  -----------
  [MachineLICM] Don't allow hoisting invariant loads across mem barrier. (#116987)

The improvements in 63917e1 / #70796 do not check for memory
barriers/unmodelled sideeffects, which means we may incorrectly hoist
loads across memory barriers.

Fix this by checking any machine instruction in the loop is a load-fold
barrier.

PR: https://github.com/llvm/llvm-project/pull/116987



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications