[all-commits] [llvm/llvm-project] 4728ac: [LLD][COFF][NFC] Always align null chunks (#116677)

[Jacek Caban via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4728ac750295af12ba484ef4b7df4f7c4893eb4c
      https://github.com/llvm/llvm-project/commit/4728ac750295af12ba484ef4b7df4f7c4893eb4c
  Author: Jacek Caban <jacek at codeweavers.com>
  Date:   2024-11-19 (Tue, 19 Nov 2024)

  Changed paths:
    M lld/COFF/DLL.cpp

  Log Message:
  -----------
  [LLD][COFF][NFC] Always align null chunks (#116677)

Currently, null chunks always follow other aligned chunks, so this patch
is NFC. However, it will become observable once support for ARM64X
imports is added. The import tables are shared between the native and EC
views. They are usually very similar, but in cases where they differ,
ARM64X relocations handle the discrepancies. If a DLL is only imported
by EC code, the native view will see it as importing zero functions from
this DLL (with ARM64X relocations replacing those null chunks with
actual imports). In this scenario, the null chunks may appear as the
very first chunks, meaning there is nothing else forcing their
alignment.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications