[all-commits] [llvm/llvm-project] 204234: [mlir][SparseTensor][NFC] Pass tensor type to desc...

Matthias Springer via All-commits all-commits at lists.llvm.org
Mon Nov 18 16:28:13 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 204234a69c068032a1adac31f00b51f3b9efa778
      https://github.com/llvm/llvm-project/commit/204234a69c068032a1adac31f00b51f3b9efa778
  Author: Matthias Springer <me at m-sp.org>
  Date:   2024-11-19 (Tue, 19 Nov 2024)

  Changed paths:
    M mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorCodegen.cpp
    M mlir/lib/Dialect/SparseTensor/Transforms/Utils/CodegenUtils.cpp
    M mlir/lib/Dialect/SparseTensor/Transforms/Utils/CodegenUtils.h
    M mlir/lib/Dialect/SparseTensor/Transforms/Utils/SparseTensorDescriptor.h

  Log Message:
  -----------
  [mlir][SparseTensor][NFC] Pass tensor type to descriptor helper (#116468)

`getDescriptorFromTensorTuple` and `getMutDescriptorFromTensorTuple`
extract the tensor type from an `unrealized_conversion_cast` op that
serves as a workaround for missing 1:N dialect conversion support.

This commit changes these functions so that they explicitly receive the
tensor type as a function argument. This is in preparation of merging
the 1:1 and 1:N conversion drivers. The conversion patterns in this file
will soon start receiving multiple SSA values (`ValueRange`) from their
adaptors (instead of a single value that is the result of
`unrealized_conversion_cast`). It will no longer be possible to take the
tensor type from the `unrealized_conversion_cast` op. The
`unrealized_conversion_cast` workaround will disappear entirely.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list