[all-commits] [llvm/llvm-project] 4548bf: [mlir][Parser] Deduplicate floating-point parsing ...

[Matthias Springer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4548bff0e8139d4f375f1078dd50a74116eae0a2
      https://github.com/llvm/llvm-project/commit/4548bff0e8139d4f375f1078dd50a74116eae0a2
  Author: Matthias Springer <me at m-sp.org>
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
    M mlir/lib/AsmParser/AsmParserImpl.h
    M mlir/lib/AsmParser/AttributeParser.cpp
    M mlir/lib/AsmParser/Parser.cpp
    M mlir/lib/AsmParser/Parser.h
    M mlir/test/IR/invalid-builtin-attributes.mlir

  Log Message:
  -----------
  [mlir][Parser] Deduplicate floating-point parsing functionality (#116172)

The following functionality is duplicated in multiple places: trying to
parse an APFloat from a floating point literal or an integer in
hexadecimal representation (bit pattern). Move it to a common helper
function.

NFC apart from the slightly changed error messages. (We now print the
exact same error messages regardless of whether the float is parsed
standalone or inside of a tensor literal, etc.)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications