[all-commits] [llvm/llvm-project] dc3156: [OpenMP] Don't hardcode _WIN32_WINNT for MinGW tar...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Sat Nov 16 01:23:36 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dc3156d8e6dc6494bc47ba074d0c990eb27b7564
      https://github.com/llvm/llvm-project/commit/dc3156d8e6dc6494bc47ba074d0c990eb27b7564
  Author: Martin Storsjö <martin at martin.st>
  Date:   2024-11-16 (Sat, 16 Nov 2024)

  Changed paths:
    M openmp/runtime/cmake/LibompDefinitions.cmake

  Log Message:
  -----------
  [OpenMP] Don't hardcode _WIN32_WINNT for MinGW targets (#115708)

Instead respect what the toolchain default is (or what the user sets via
CMAKE_CXX_FLAGS).

This fixes builds with libcxx, with mingw toolchains targeting
msvcrt.dll, after 5d8be4c036aa5ce4a94f1f37a9155d5c877e23db; after that
commit, the libcxx public headers reference symbols such as iswspace_l,
which are unavailable when targeting msvcrt.dll on older versions of
Windows (it's only available in msvcrt.dll since Windows Vista).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list