[all-commits] [llvm/llvm-project] 9513f2: [MemProf] Print full context hash when reporting h...

[Teresa Johnson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9513f2fdf2ad50f55726154a6b6a4aa463bc457f
      https://github.com/llvm/llvm-project/commit/9513f2fdf2ad50f55726154a6b6a4aa463bc457f
  Author: Teresa Johnson <tejohnson at google.com>
  Date:   2024-11-15 (Fri, 15 Nov 2024)

  Changed paths:
    M llvm/include/llvm/Analysis/MemoryProfileInfo.h
    M llvm/include/llvm/Bitcode/LLVMBitCodes.h
    M llvm/include/llvm/IR/ModuleSummaryIndex.h
    M llvm/lib/Analysis/MemoryProfileInfo.cpp
    M llvm/lib/Analysis/ModuleSummaryAnalysis.cpp
    M llvm/lib/Bitcode/Reader/BitcodeAnalyzer.cpp
    M llvm/lib/Bitcode/Reader/BitcodeReader.cpp
    M llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
    M llvm/lib/IR/Verifier.cpp
    M llvm/lib/Transforms/IPO/MemProfContextDisambiguation.cpp
    M llvm/lib/Transforms/Instrumentation/MemProfiler.cpp
    M llvm/test/ThinLTO/X86/memprof-aliased-location1.ll
    M llvm/test/ThinLTO/X86/memprof-aliased-location2.ll
    M llvm/test/ThinLTO/X86/memprof-basic.ll
    M llvm/test/Transforms/MemProfContextDisambiguation/aliased-location1.ll
    M llvm/test/Transforms/MemProfContextDisambiguation/aliased-location2.ll
    M llvm/test/Transforms/MemProfContextDisambiguation/basic.ll
    M llvm/test/Transforms/PGOProfile/memprof.ll
    M llvm/test/Verifier/memprof-metadata-bad.ll

  Log Message:
  -----------
  [MemProf] Print full context hash when reporting hinted bytes (#114465)

Improve the information printed when -memprof-report-hinted-sizes is
enabled. Now print the full context hash computed from the original
profile, similar to what we do when reporting matching statistics. This
will make it easier to correlate with the profile.

Note that the full context hash must be computed at profile match time
and saved in the metadata and summary, because we may trim the context
during matching when it isn't needed for distinguishing hotness.
Similarly, due to the context trimming, we may have more than one full
context id and total size pair per MIB in the metadata and summary,
which now get a list of these pairs.

Remove the old aggregate size from the metadata and summary support.
One other change from the prior support is that we no longer write the
size information into the combined index for the LTO backends, which
don't use this information, which reduces unnecessary bloat in
distributed index files.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications