[all-commits] [llvm/llvm-project] 5bbe63: fix: Target Process may crash or freezes on detach...

[anatawa12 via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5bbe63ec91226c0026c6f1ed726c45bb117544e0
      https://github.com/llvm/llvm-project/commit/5bbe63ec91226c0026c6f1ed726c45bb117544e0
  Author: anatawa12 <anatawa12 at icloud.com>
  Date:   2024-11-15 (Fri, 15 Nov 2024)

  Changed paths:
    M lldb/source/Plugins/Process/Windows/Common/DebuggerThread.cpp
    M lldb/source/Plugins/Process/Windows/Common/DebuggerThread.h
    M lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
    M lldb/test/API/commands/process/detach-resumes/TestDetachResumes.py

  Log Message:
  -----------
  fix: Target Process may crash or freezes on detaching process on windows (#115712)

Fixes #67825 Fixes #89077

Fixes
[RIDER-99436](https://youtrack.jetbrains.com/issue/RIDER-99436/Unity-Editor-will-be-crashed-when-detaching-LLDB-debugger-in-Rider),
which is upstream issue of #67825.

This PR changes the timing of calling `DebugActiveProcessStop` to after
calling `ContinueDebugEvent` for last debugger exception.

I confirmed the crashing behavior is because we call
`DebugActiveProcessStop` before `ContinueDebugEvent` for last debugger
exception with https://github.com/anatawa12/debug-api-test.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications