[all-commits] [llvm/llvm-project] 478c24: [HLSL] Add implicit resource element type concepts...

[Joshua Batista via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 478c24b5f86911d14256bad71c85ed0ff061070a
      https://github.com/llvm/llvm-project/commit/478c24b5f86911d14256bad71c85ed0ff061070a
  Author: Joshua Batista <jbatista at microsoft.com>
  Date:   2024-11-14 (Thu, 14 Nov 2024)

  Changed paths:
    M clang/lib/Sema/HLSLExternalSemaSource.cpp
    M clang/test/AST/HLSL/RWBuffer-AST.hlsl
    M clang/test/AST/HLSL/StructuredBuffer-AST.hlsl
    A clang/test/AST/HLSL/is_typed_resource_element_compatible_concept.hlsl
    M clang/test/SemaHLSL/BuiltIns/RWBuffers.hlsl
    M clang/test/SemaHLSL/BuiltIns/StructuredBuffers.hlsl

  Log Message:
  -----------
  [HLSL] Add implicit resource element type concepts to AST (#112600)

This PR is step one on the journey to implement resource element type
validation via C++20 concepts. The PR sets up the infrastructure for
injecting implicit concept decls / concept specialization expressions
into the AST, which will then be evaluated after template arguments are
instantiated. This is not meant to be a complete implementation of the
desired validation for HLSL,
there are a couple of missing elements:
1. We need the __builtin_hlsl_is_typed_resource_element_compatible
builtin to be implemented.
2. We need other constraints, like is_intangible
3. We need to put the first 2 points together, and construct a finalized
constraint expression, which should differ between typed and raw buffers

This is just an initial PR that puts some of the core infrastructure in
place.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications