[all-commits] [llvm/llvm-project] d68332: [flang] Fix spurious error messages due to INTRINS...

[Peter Klausler via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d68332d0627f6492866298038e1085e4aff0f476
      https://github.com/llvm/llvm-project/commit/d68332d0627f6492866298038e1085e4aff0f476
  Author: Peter Klausler <pklausler at nvidia.com>
  Date:   2024-11-14 (Thu, 14 Nov 2024)

  Changed paths:
    M flang/lib/Semantics/resolve-names.cpp
    A flang/test/Semantics/bug115674.f90

  Log Message:
  -----------
  [flang] Fix spurious error messages due to INTRINSIC nested in BLOCK (#115889)

When skimmming executable parts to collect names used in procedure
calls, it is important to exclude names that have local declarations in
nested BLOCK constructs. The mechanism for handling these nested
declarations was catching only names whose declarations include an
"entity-decl", and so names appearing in other declaration statements
(like INTRINSIC and EXTERNAL statements) were not hidden from the scan,
leading to absurd error messages when such names turn out to be
procedures in the nested BLOCK construct but to not be procedures
outside it.

This patch fixes the code that detects local declarations in BLOCK for
all of the missed cases that don't use entity-decls; only INTRINSIC and
EXTERNAL could affect the procedures whose names are of interest to the
executable part skimmer, but perhaps future work will want to collect
non-procedures as well, so I plugged all of the holes that I could find.

Fixes https://github.com/llvm/llvm-project/issues/115674.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications