[all-commits] [llvm/llvm-project] 001956: [RISCV] Don't create BuildPairF64 or SplitF64 node...

[Craig Topper via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0019565e9322350145c2b3bbc06a3a042f3a8ee1
      https://github.com/llvm/llvm-project/commit/0019565e9322350145c2b3bbc06a3a042f3a8ee1
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2024-11-14 (Thu, 14 Nov 2024)

  Changed paths:
    M llvm/lib/Target/RISCV/RISCVISelLowering.cpp
    A llvm/test/CodeGen/RISCV/rvv/rv32-zve-bitcast-crash.ll

  Log Message:
  -----------
  [RISCV] Don't create BuildPairF64 or SplitF64 nodes without D or Zdinx. (#116159)

The fix in ReplaceNodeResults is the only one really required for the
known crash.

I couldn't hit the case in LowerOperation because that requires (f64
(bitcast i64)), but the result type is softened before the input so we
don't get a chance to legalize the input.

The change to the setOperationAction call was an observation that a
i64<->vector cast should not be custom legalized on RV32. The custom
code already calls isTypeLegal on the scalar type.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications