[all-commits] [llvm/llvm-project] 3d3b0b: [lldb] Disable find-module.test in case of a remot...

[Dmitry Vasilyev via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3d3b0bc239cd9c6e8c65ae26bdcf1534515c4beb
      https://github.com/llvm/llvm-project/commit/3d3b0bc239cd9c6e8c65ae26bdcf1534515c4beb
  Author: Dmitry Vasilyev <dvassiliev at accesssoftek.com>
  Date:   2024-11-14 (Thu, 14 Nov 2024)

  Changed paths:
    M lldb/test/Shell/Minidump/Windows/find-module.test

  Log Message:
  -----------
  [lldb] Disable find-module.test in case of a remote target (#94165)

The target arch is `i386-pc-windows` after loading the dump. It updates
to `i386-pc-windows-msvc` or `i386-pc-windows-gnu` in
lldb\source\Plugins\Process\minidump\ProcessMinidump.cpp, line 218
```
GetTarget().MergeArchitecture(module->GetArchitecture());
```
But in case of the remote target (`remote-linux`) and the `Windows host`
lldb executed the following commands at the beginning
```
platform select remote-linux
platform connect connect://<ip>:<port>
```
and then the target arch is `i386-pc-windows-msvc` immediately after
loading the dump.
GetTarget().MergeArchitecture(module->GetArchitecture()) does not update
it to `i386-pc-windows-gnu` when the module arch is
`i386-pc-windows-gnu`.

---------

Co-authored-by: Pavel Labath <pavel at labath.sk>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications