[all-commits] [llvm/llvm-project] 4df531: [mlir][spirv] Use assemblyFormat to define groupNo...

Yadong Chen via All-commits all-commits at lists.llvm.org
Wed Nov 13 08:33:56 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4df5310ffc82c0382f508d969e19521200ab357b
      https://github.com/llvm/llvm-project/commit/4df5310ffc82c0382f508d969e19521200ab357b
  Author: Yadong Chen <cyd.matt at qq.com>
  Date:   2024-11-13 (Wed, 13 Nov 2024)

  Changed paths:
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVGroupOps.td
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVNonUniformOps.td
    M mlir/lib/Dialect/SPIRV/IR/GroupOps.cpp
    M mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp
    M mlir/test/Conversion/ConvertToSPIRV/argmax-kernel.mlir
    M mlir/test/Conversion/ConvertToSPIRV/gpu.mlir
    M mlir/test/Conversion/GPUToSPIRV/reductions.mlir
    M mlir/test/Dialect/SPIRV/IR/group-ops.mlir
    M mlir/test/Dialect/SPIRV/IR/non-uniform-ops.mlir
    M mlir/test/Dialect/SPIRV/Transforms/vce-deduction.mlir
    M mlir/test/Target/SPIRV/debug.mlir
    M mlir/test/Target/SPIRV/group-ops.mlir
    M mlir/test/Target/SPIRV/non-uniform-ops.mlir

  Log Message:
  -----------
  [mlir][spirv] Use assemblyFormat to define groupNonUniform op assembly (#115662)

Declarative assemblyFormat ODS is more concise and requires less
boilerplate than filling out CPP interfaces.

Changes:
* updates the Ops defined in `SPIRVNonUniformOps.td and
SPIRVGroupOps.td` to use assemblyFormat.
* Removes print/parse from `GroupOps.cpp` which is now generated by
assemblyFormat
* Updates tests to updated format (largely using <operand> in place of
"operand" and complementing type information)

Issue: #73359



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list