[all-commits] [llvm/llvm-project] 39b297: [lldb] Fix source display for artificial locations...

[Pavel Labath via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 39b2979a434e70a4ce76d4adf91572dcfc9662ff
      https://github.com/llvm/llvm-project/commit/39b2979a434e70a4ce76d4adf91572dcfc9662ff
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2024-11-13 (Wed, 13 Nov 2024)

  Changed paths:
    M lldb/include/lldb/Symbol/Function.h
    M lldb/source/Breakpoint/BreakpointResolverFileLine.cpp
    M lldb/source/Commands/CommandObjectSource.cpp
    M lldb/source/Core/Disassembler.cpp
    M lldb/source/Symbol/Function.cpp
    M lldb/source/Target/StackFrame.cpp
    M lldb/test/API/source-manager/TestSourceManager.py
    R lldb/test/API/source-manager/artificial_location.c
    A lldb/test/API/source-manager/artificial_location.cpp
    A lldb/test/API/source-manager/artificial_location.h

  Log Message:
  -----------
  [lldb] Fix source display for artificial locations (#115876)

When retrieving the location of the function declaration, we were
dropping the file component on the floor, which resulted in an amusingly
confusing situation were we displayed the file containing the
implementation of the function, but used the line number of the
declaration. This patch fixes that.

It required a small refactor Function::GetStartLineSourceLineInfo to
return a SupportFile (instead of just the file spec), which in turn
necessitated changes in a couple of other places as well.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications