[all-commits] [llvm/llvm-project] ae7b5a: [lldb] Remove ConnectionFileDescriptor::child_proc...

Pavel Labath via All-commits all-commits at lists.llvm.org
Wed Nov 13 00:00:04 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ae7b5af904850db71308915836f32a8d79553dd8
      https://github.com/llvm/llvm-project/commit/ae7b5af904850db71308915836f32a8d79553dd8
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2024-11-13 (Wed, 13 Nov 2024)

  Changed paths:
    M lldb/include/lldb/Host/posix/ConnectionFileDescriptorPosix.h
    M lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp

  Log Message:
  -----------
  [lldb] Remove ConnectionFileDescriptor::child_process_inherit (#115861)

It's never set to true. Inheritable FDs are also dangerous as they can
end up processes which know nothing about them. It's better to
explicitly pass a specific FD to a specific subprocess, which we already
mostly can do using the ProcessLaunchInfo FileActions.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list