[all-commits] [llvm/llvm-project] 9d85ba: [SandboxIR] Preserve the order of switch cases aft...

[Jorge Gorbe Moya via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9d85ba5724f22d73c95858246691e0b389bdb28d
      https://github.com/llvm/llvm-project/commit/9d85ba5724f22d73c95858246691e0b389bdb28d
  Author: Jorge Gorbe Moya <jgorbe at google.com>
  Date:   2024-11-12 (Tue, 12 Nov 2024)

  Changed paths:
    M llvm/include/llvm/SandboxIR/Tracker.h
    M llvm/lib/SandboxIR/Instruction.cpp
    M llvm/lib/SandboxIR/Tracker.cpp
    M llvm/unittests/SandboxIR/TrackerTest.cpp

  Log Message:
  -----------
  [SandboxIR] Preserve the order of switch cases after revert. (#115577)

Preserving the case order is not strictly necessary to preserve
semantics (for example, operations like SwitchInst::removeCase will
happily swap cases around). However, I'm planning to introduce an
optional verification step for SandboxIR that will use StructuralHash to
compare IR after a revert to the original IR to help catch tracker bugs,
and the order difference triggers a difference there.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications