[all-commits] [llvm/llvm-project] 014455: [SDAG] Limit sincos/frexp stack slot folding to st...

Benjamin Maxwell via All-commits all-commits at lists.llvm.org
Tue Nov 12 12:49:02 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 014455a58762331b8eb7962c60bd64168c49f3b4
      https://github.com/llvm/llvm-project/commit/014455a58762331b8eb7962c60bd64168c49f3b4
  Author: Benjamin Maxwell <benjamin.maxwell at arm.com>
  Date:   2024-11-12 (Tue, 12 Nov 2024)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
    M llvm/test/CodeGen/PowerPC/f128-arith.ll
    M llvm/test/CodeGen/RISCV/llvm.frexp.ll
    M llvm/test/CodeGen/X86/llvm.frexp.ll
    A llvm/test/CodeGen/X86/sincos-stack-args.ll

  Log Message:
  -----------
  [SDAG] Limit sincos/frexp stack slot folding to stores chained to entry (#115906)

When the chain is not the entry node there is a risk the stores are
within a (CALLSEQ_START, CALLSEQ_END), which when the node is expanded
will lead to nested call sequences.

It should be possible to check for this and allow more cases, but for
now, let's limit this to cases where it's definitely safe.

Fixes #115323



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list