[all-commits] [llvm/llvm-project] a93cbd: [SPIRV] Audit `select` Result in SPIRVInstructionS...

[Finn Plummer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a93cbd4e762799206ae6e6c45f4a7d0da7e56513
      https://github.com/llvm/llvm-project/commit/a93cbd4e762799206ae6e6c45f4a7d0da7e56513
  Author: Finn Plummer <50529406+inbelic at users.noreply.github.com>
  Date:   2024-11-12 (Tue, 12 Nov 2024)

  Changed paths:
    M llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp

  Log Message:
  -----------
  [SPIRV] Audit `select` Result in SPIRVInstructionSelector (#115193)

- as per the definition of `select` in GlobalISel/InstructionSelector.h
the return value is a boolean denoting if the select was successful
- doing `Result |=` is incorrect as all inserted instructions should be
succesful, hence we change to using `Result &=`
- ensure that the return value of all BuildMI instructions are
propagated correctly



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications