[all-commits] [llvm/llvm-project] e65c54: [mlir][IR] `DominanceInfo`: Deduplicate `properlyD...

[Matthias Springer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e65c5428adab477331cf0a57b540e77850807843
      https://github.com/llvm/llvm-project/commit/e65c5428adab477331cf0a57b540e77850807843
  Author: Matthias Springer <me at m-sp.org>
  Date:   2024-11-12 (Tue, 12 Nov 2024)

  Changed paths:
    M mlir/include/mlir/IR/Dominance.h
    M mlir/lib/IR/Dominance.cpp

  Log Message:
  -----------
  [mlir][IR] `DominanceInfo`: Deduplicate `properlyDominates` implementation (#115433)

The implementations of `DominanceInfo::properlyDominates` and
`PostDominanceInfo::properlyPostDominates` are almost identical: only
one line of code is different (apart from the missing `enclosingOpOk`
flag). Define the function in `DominanceInfoBase` to avoid the code
duplication.

Also rename the helper in `DominanceInfoBase` to
`properlyDominatesImpl`.

Note: This commit is not marked as NFC because
`PostDominanceInfo::properlyPostDominates` now also has an
`enclosingOpOk` argument.

Depends on #115430.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications