[all-commits] [llvm/llvm-project] 1ae0da: [libc] Clean up skipped and failing cmake (#115400)

[Michael Jones via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1ae0dae368e4bbf2177603d5c310e794c4fd0bd8
      https://github.com/llvm/llvm-project/commit/1ae0dae368e4bbf2177603d5c310e794c4fd0bd8
  Author: Michael Jones <michaelrj at google.com>
  Date:   2024-11-11 (Mon, 11 Nov 2024)

  Changed paths:
    M libc/config/linux/x86_64/entrypoints.txt
    M libc/src/stdio/scanf_core/reader.h
    M libc/src/stdio/sscanf.cpp
    M libc/src/wchar/CMakeLists.txt
    M libc/src/wchar/btowc.cpp
    M libc/test/integration/src/unistd/CMakeLists.txt
    M libc/test/src/math/smoke/CMakeLists.txt
    M libc/test/src/stdio/scanf_core/CMakeLists.txt
    M libc/test/src/stdio/scanf_core/converter_test.cpp
    M libc/test/src/sys/statvfs/linux/CMakeLists.txt
    M libc/test/src/sys/statvfs/linux/fstatvfs_test.cpp
    M libc/test/src/sys/statvfs/linux/statvfs_test.cpp

  Log Message:
  -----------
  [libc] Clean up skipped and failing cmake (#115400)

I normally run my cmake with LIBC_CMAKE_VERBOSE_LOGGING set to ON so I
can debug build issues more easily. One of the effects of this is I see
which tests/entrypoints are skipped on my machine. This patch fixes up
the tests and entrypoints that were skipped, but easily fixed. These
were:

libc.src.pthread.pthread_spin_destroy
libc.src.pthread.pthread_spin_init
libc.src.pthread.pthread_spin_lock
libc.src.pthread.pthread_spin_trylock
libc.src.pthread.pthread_spin_unlock
(entrypoints were just missing)

libc.src.wchar.btowc
(I forgot to finish it)

libc.test.src.sys.statvfs.linux.statvfs_test
libc.test.src.sys.statvfs.linux.fstatvfs_test
(Incorrect includes for rmdir, needed some cleanup)

libc.test.integration.src.unistd.execve_test
(wrong dep for errno)

libc.test.src.math.smoke.fmaf_test
(add_fp_unittest doesn't support flags)

libc.test.src.stdio.scanf_core.converter_test
(needed to be moved away from string_reader, further cleanup needed)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications