[all-commits] [llvm/llvm-project] 8883b7: [Windows] Emit dependency to flang_rt.builtins.lib...

[Michael Kruse via All-commits]

  Branch: refs/heads/users/meinersbur/flang_runtime
  Home:   https://github.com/llvm/llvm-project
  Commit: 8883b7e5b8e91db5a729b89fca6e61579b520107
      https://github.com/llvm/llvm-project/commit/8883b7e5b8e91db5a729b89fca6e61579b520107
  Author: Michael Kruse <llvm-project at meinersbur.de>
  Date:   2024-11-11 (Mon, 11 Nov 2024)

  Changed paths:
    M clang/lib/Driver/ToolChains/Flang.cpp
    M flang-rt/cmake/modules/AddFlangRT.cmake

  Log Message:
  -----------
  [Windows] Emit dependency to flang_rt.builtins.lib in every flang-compiled object file.

The dependency is already transitive due to flang-rt depending on it, so
it shouldn't be necessary. However, CMake may depend on it, and the
transsitivity may be ignored in DLLs.

To avoid breaking things, keep the original behaviour but remove the
redundant condition and update the wrong comment.

IMHO this is a bug in LLVM: If clang/clang-cl emits calls not in user-code,
the driver should als care about linking the correct library. Even better,
do not generate such calls and adhere to the msvc-defined ABI.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications